lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun,  8 Nov 2009 16:28:56 +0100
From:	Frederic Weisbecker <>
To:	Ingo Molnar <>
Cc:	LKML <>,
	Paul Mundt <>,
	Li Zefan <>,
	Prasad <>,
	Alan Stern <>,
	Peter Zijlstra <>,
	Arnaldo Carvalho de Melo <>,
	Steven Rostedt <>,
	Jan Kiszka <>,
	Jiri Slaby <>, Avi Kivity <>,
	Paul Mackerras <>,
	Mike Galbraith <>,
	Masami Hiramatsu <>,
	Arjan van de Ven <>,
	Ingo Molnar <>,
	Frederic Weisbecker <>
Subject: [PATCH 2/7 v6] x86/hw-breakpoints: Actually flush thread breakpoints in flush_thread().

From: Paul Mundt <>

flush_thread() tries to do a TIF_DEBUG check before calling in to
flush_thread_hw_breakpoint() (which subsequently clears the thread flag),
but for some reason, the x86 code is manually clearing TIF_DEBUG
immediately before the test, so this path will never be taken.

This kills off the erroneous clear_tsk_thread_flag() and lets
flush_thread_hw_breakpoint() actually get invoked.

Presumably folks were getting lucky with testing and the
free_thread_info() -> free_thread_xstate() path was taking care of the
flush there.

Signed-off-by: Paul Mundt <>
Acked-by: "K.Prasad" <>
Cc: Ingo Molnar <>
Cc: Alan Stern <>
LKML-Reference: <>
Signed-off-by: Frederic Weisbecker <>
 arch/x86/kernel/process.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 2275ce5..cf8ee00 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -107,8 +107,6 @@ void flush_thread(void)
-	clear_tsk_thread_flag(tsk, TIF_DEBUG);
 	if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG)))
 	memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array));

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists