lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 8 Nov 2009 13:36:31 -0200
From:	André Goddard Rosa <>
To:	Ingo Molnar <>
Cc:	Frederic Weisbecker <>,,,,,
	linux list <>
Subject: Re: [PATCH v3 1/7] vsprintf: factorize "(null)" string

Hi, Ingo!

On Sun, Nov 8, 2009 at 9:02 AM, Ingo Molnar <> wrote:
> * Andr? Goddard Rosa <> wrote:
>> @@ -546,12 +548,12 @@ static char *number(char *buf, char *end,
>> unsigned long long num,
>>       return buf;
>>  }
>> -static char *string(char *buf, char *end, char *s, struct printf_spec spec)
>> +static char *string(char *buf, char *end, const char *s, struct
>> printf_spec spec)
> FYI, your patches have such linewraps, so the patches wont apply:
>  patch: **** malformed patch at line 47: unsigned long long num,
> See Documentation/email-clients.txt about how to send patches without
> such problems.
> Mind resending with this fixed?

I tried to fix these by using send-email this time. Please let me know
if you still see any issue.

> Also, this RFC patch of yours:
>  vsprintf: reuse almost identical simple_strtoulX() functions
> looks nice too IMO - mind including it in your series?

Can I consider it as an Acked-by?  ;-)

Just sent v4 now.

Thank you,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists