linux-kernel - Re: [PATCH] trivial: fix checking socket() in net tstamp example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091108175704.GB820@lilem.mirepesht>
Date:	Sun, 8 Nov 2009 21:27:04 +0330
From:	Ali Gholami Rudi <ali@...i.ir>
To:	Patrick Ohly <patrick.ohly@...el.com>
Cc:	"trivial@...nel.org" <trivial@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example

Hi Patrick,

Patrick Ohly <patrick.ohly@...el.com> wrote:
> > --- a/Documentation/networking/timestamping/timestamping.c
> > +++ b/Documentation/networking/timestamping/timestamping.c
> > @@ -370,7 +370,7 @@ int main(int argc, char **argv)
> >  	}
> >  
> >  	sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
> > -	if (socket < 0)
> > +	if (sock < 0)
> 
> Argh, of course you are right. FWIW, acknowledged.

By the way, I tried igb hardware timestamp but HWTSTAMP_FILTER_ALL works
almost like HWTSTAMP_FILTER_PTP_*.  Isn't it supposed to timestamp all
of the incoming packets?  Maybe there is something wrong with my test
setup?

Thanks,
Ali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/