linux-kernel - Re: [RFC, PATCH 0/7] net, compat_ioctl: move handlers to net/socket.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911082231.48060.arnd@arndb.de>
Date:	Sun, 8 Nov 2009 22:31:47 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, hch@....de, netdev@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [RFC, PATCH 0/7] net, compat_ioctl: move handlers to net/socket.c

On Saturday 07 November 2009, David Miller wrote:
> From: Arnd Bergmann <arnd@...db.de>
> Date: Fri,  6 Nov 2009 19:09:02 +0100
> 
> > This cleans up some of the socket ioctl handling by moving it
> > from fs/compat_ioctl.c to net/socket.c. The code is still untested,
> > so this is an RFC for now. If you're happy with it, I'll do some
> > testing to see if everything still works.
> > 
> > This series is a prerequisite for cleaning up the rest of
> > compat_ioctl.c, saving some 30kb of kernel memory in the end.
> > 
> > The first four patches are probably worthwhile independently,
> > because they fix some bugs in compat_ioctl handling.
> > There is some obvious conflict with the ATM patch I sent
> > independently today. That one should probably be worked out
> > first.
> 
> This looks great, all applied.  Please make the fixups recommended
> to you in the feedback as followon patches.

Thanks! Two patches follow.

Any opinion on how to proceed with the ATM stuff? From my
point of view, I'm fine with having moved it out of fs/compat_ioctl.c,
but it's still a bit silly to have two half-complete implementations.

> Also, I added the following cure after your patch series:
> 
> net: compat: No need to define IFHWADDRLEN and IFNAMSIZ twice.
> 
> It's defined colloqually in linux/if.h and linux/compat.h
> includes that.

ok.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/