lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 08 Nov 2009 00:28:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	sparclinux@...r.kernel.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc,sparc64: replace parentheses in pmul()

From: Roel Kluin <roel.kluin@...il.com>
Date: Thu, 05 Nov 2009 17:40:44 +0100

> `>>' has a higher precedence than `?' so src2 evaluated to
> either 16 or 0 dependent on the bits set in rs2.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  arch/sparc/kernel/visemul.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> I am not 100% sure that the code was incorrect, however, if it
> was intended I think it is a very strange way to write it.

Your fix is correct, thanks Roel!

I really need to write a testsuite for this VIS emulation code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists