linux-kernel - Re: [PATCH] x86: sched: fix for non SMP systems in sched.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091108115256.GR11372@elte.hu>
Date:	Sun, 8 Nov 2009 12:52:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Ralf R??sch <ralf.roesch@...gmbh.de>
Cc:	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
	hpa@...or.com, mingo@...hat.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86: sched: fix for non SMP systems in sched.h


* Ralf R??sch <ralf.roesch@...gmbh.de> wrote:

> commit d65d153bc23b84e4709a49137a9a03ae139d51a0 introduced
> two new prototypes: default_scale_freq_power and default_scale_smt_power.
> Both of them use struct sched_domain which is not defined on non SMP
> systems.
> Just moved the prototypes to the correct place.
> 
> Signed-off-by: Ralf Roesch <ralf.roesch@...gmbh.de>
> ---
> include/linux/sched.h |    7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
> mode change 100644 => 100755 include/linux/sched.h
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> old mode 100644
> new mode 100755
> index c231a24..b633308
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1036,6 +1036,9 @@ static inline int test_sd_parent(struct
> sched_domain *sd, int flag)
>     return 0;
> }
> 
> +unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
> +unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
> +
> #else /* CONFIG_SMP */
> 
> struct sched_domain_attr;
> @@ -1047,10 +1050,6 @@ partition_sched_domains(int ndoms_new, struct
> cpumask *doms_new,
> }
> #endif    /* !CONFIG_SMP */
> 
> -
> -unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
> -unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
> -
> struct io_context;            /* See blkdev.h */

FYI, your patch has tabs converted to spaces (and line-wrap problems), 
so it wont apply cleanly.

See Documentation/email-clients.txt about how to send patches without
such problems.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/