linux-kernel - Re: [GIT]: IDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Nov 2009 11:35:08 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT]: IDE

On Monday 09 November 2009 06:30:55 David Miller wrote:
> 
> The revert we thought we didn't need, we really do need still, even
> with Bart Z.'s fix.
> 
> The issue is that we are doing these PIO setting calls before we did
> the device probe and therefore we don't yet know the media type.
> 
> Yet the ->set_pio_mode() of some drivers key off of the media type to
> determine whether to turn prefetching etc. on so it can't possibly
> work properly.

Thanks for quick reaction to the revert request.

If somebody is interested in the proper way to fix it you just need to
add ide_unknown media type and set it before probe instead of ide_disk
one.  Then audit ->set_pio_mode implementations for potential gotchas.

[ However it is too late for -rc and nobody is currently working on
  IDE fixes anyway so I just requested the revert . ]

-- 
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/