lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Nov 2009 17:38:39 +0530 From: Amit Shah <amit.shah@...hat.com> To: Rusty Russell <rusty@...tcorp.com.au> Cc: Anthony Liguori <aliguori@...ibm.com>, linux-kernel@...r.kernel.org, virtualization@...ux-foundation.org, Christian Borntraeger <borntraeger@...ibm.com>, "Michael S. Tsirkin" <mst@...hat.com> Subject: Re: [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication Hey Rusty, On (Fri) Nov 06 2009 [17:40:02], Rusty Russell wrote: > On Wed, 4 Nov 2009 03:08:39 am Amit Shah wrote: > > Expose multiple char devices ("ports") for simple communication > > between the host userspace and guest. > > OK, I've taken the chance to audit this patch. I started adding patches > until I got overwhelmed. It's a complete mess and needs a total rewrite :( > > This shows the problem with feeding me a complete driver rewrite in one > big hit. You've combined lots of changes and techniques in here at once: I'm really sorry for dumping this all at once. I've separated out the patches for easier reviewing, the result passes my tests but I'm going to give them some more time to run. > Less important nitpicks: ... > 3) Don't use list_for_each_safe() to get the head entry of a list. Your > use is buggy anyway: buf will never be NULL afterwards. As long as 'head' isn't the only node in the list we should loop. And list_foreach_safe() does that. So it's OK right? > In summary: this is the one we're going to throw away. > > Now I'm going to start again, one patch at a time, and see how that works. I'm sorry for having created more work for you; I'll send out my patches to you in a couple of days. Thanks! Amit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists