lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Nov 2009 03:26:42 +0100 From: Frederic Weisbecker <fweisbec@...il.com> To: Wu Zhangjin <wuzhangjin@...il.com> Cc: linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org, rostedt@...dmis.org, Thomas Gleixner <tglx@...utronix.de>, Ralf Baechle <ralf@...ux-mips.org>, Richard Sandiford <rdsandiford@...glemail.com>, Nicholas Mc Guire <der.herr@...r.at>, David Daney <ddaney@...iumnetworks.com>, Adam Nemet <anemet@...iumnetworks.com>, Patrik Kluba <kpajko79@...il.com> Subject: Re: [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section for MIPS On Mon, Oct 26, 2009 at 11:13:25PM +0800, Wu Zhangjin wrote: > This patch add a new section for MIPS to record the block of the hardirq > handling for function graph tracer(print_graph_irq) via adding the > __irq_entry annotation to the the entrypoints of the hardirqs(the block > with irq_enter()...irq_exit()). > > Thanks goes to Steven & Frederic Weisbecker for their feedbacks. > > Signed-off-by: Wu Zhangjin <wuzhangjin@...il.com> > + > +/* > + * do_IRQ handles all normal device IRQ's (the special > + * SMP cross-CPU interrupts have their own specific > + * handlers). > + */ > +unsigned int __irq_entry do_IRQ(unsigned int irq) > +{ > + irq_enter(); > + __DO_IRQ_SMTC_HOOK(irq); > + generic_handle_irq(irq); > + irq_exit(); > + > + return 1; > +} Nano-neat: Why is it returning a value, it doesn't seem needed (the macro version didn't)? Anyway, that looks good to me. I hope the changes from macro to function calls will be ack by the MIPS maintainers. Reviewed-by: Frederic Weisbecker <fweisbec@...il.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists