linux-kernel - Re: [PATCH 70/75] cxacru: declare MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bdb0f53eaa2c42735b3a575b2dfaa6c8d97131ae@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid>
Date:	Mon, 9 Nov 2009 12:42:07 -0000
From:	"Simon Arlott" <simon@...e.lp0.eu>
To:	"Ben Hutchings" <ben@...adent.org.uk>
Cc:	"Greg Kroah-Hartman" <gregkh@...e.de>,
	accessrunner-general@...ts.sourceforge.net,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 70/75] cxacru: declare MODULE_FIRMWARE

On Sat, November 7, 2009 22:19, Ben Hutchings wrote:
> On Sat, 2009-11-07 at 22:16 +0000, Simon Arlott wrote:
>> On 07/11/09 22:09, Ben Hutchings wrote:
>> > +++ b/drivers/usb/atm/cxacru.c
>> > +MODULE_FIRMWARE("cxacru-fw.bin");
>> > +MODULE_FIRMWARE("cxacru-bp.bin");
>>
>> It also optionally loads "cxacru-cf.bin".
>
> I saw that, but thought it better not to list optional files.

In that case, "cxacru-bp.bin" is optional as only certain versions
of the device require it.

Perhaps MODULE_FIRMWARE() should have an "optional" flag too, so
that all files can be listed?

-- 
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/