linux-kernel - Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b8bf37780911090602j21b0022cg695d9e20b8a88660@mail.gmail.com>
Date:	Mon, 9 Nov 2009 12:02:13 -0200
From:	André Goddard Rosa <andre.goddard@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux list <linux-kernel@...r.kernel.org>,
	Jan Engelhardt <jengelh@...ozas.de>,
	James Bottomley <James.Bottomley@...senpartnership.com>
Subject: Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to 
	be generally available

On Sun, Nov 8, 2009 at 2:50 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> On Sat,  7 Nov 2009 13:16:18 -0200
> André Goddard Rosa <andre.goddard@...il.com> wrote:
>
>> On the following sentence:
>>     while (*s && isspace(*s))
>>         s++;
>
> Looks fine but for one thing: it's actually shorter inline than moved
> into /lib so at the very least it should be a header inline not a
> function call.

I have tried header "static inline" approach per your suggestion and
code size increases by 197 bytes from:
64954     584     588   66126   1024e (TOTALS-lib.a-before)
to:
65151     584     588   66323   10313 (TOTALS-lib.a-after)

> Second minor comment. Although it never made it into the final ANSI C,
> the proposed name (and the one used in a lot of other non Linux code for
> this) is stpblk().

Thank you,
André
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/