linux-kernel - Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091109142430.GZ1773@smtp.gmail.com>
Date:	Mon, 9 Nov 2009 16:24:30 +0200
From:	Amit Kucheria <amit.kucheria@...durent.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	List Linux Kernel <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

On 09 Nov 09, Jonathan Cameron wrote:
> Hi Amit,
> 
> Normally I'd welcome this in IIO, except that all ambient light sensors are in the
> process of moving to the new ALS subsystem.  There are still some issues to resolve
> in that subsystem (mainly to do with naming conventions) but hopefully we will
> get them sorted out shortly.

Groan! :) Who will be the subsystem maintainer and is there already a public git
tree?

> I'll take a close look at this sometime over the next few days though.  On a quick
> glance at the data sheet, it looks very similar to the tsl2561.  Perhaps we can merge
> the drivers? Yours is certainly more complete than the tsl2561 version in IIO so it
> would make sense to lift the functional elements in to the code I have for an ALS
> driver. I hadn't posted that previously as I hadn't quite worked out how to handle
> the various gain related settings. What you have done seems to make sense (from a very
> quick look.)

I've got no problem merging the tsl2563 with 2561. I don't have any 2561
hardware to check a merged driver though.


Do you think the ALS framework will be finalised before the 2.6.33 merge
window (in a few weeks)? If not, I wonder if Greg would take this driver to
staging to begin with and I'll modify it to use the ALS subsystem when it
settles down.

Regards,
Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/