| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091109190219.GB15159@caffeine.csclub.uwaterloo.ca> Date: Mon, 9 Nov 2009 19:02:19 +0000 From: lsorense@...lub.uwaterloo.ca (Lennart Sorensen) To: linux-kernel@...r.kernel.org Cc: Len Sorensen <lsorense@...lub.uwaterloo.ca>, netdev@...r.kernel.org, Paulius Zaleckas <paulius.zaleckas@...tonika.lt>, Laurent Pinchart <laurentp@...-semaphore.com> Subject: Fix gpio-mdio driver to work for gpio's that return something other than 0 and 1. The gpio-mdio driver seems to assume GPIOs return 0 and 1, although that doesn't seem to be the case. I see return values of 0 and 0x1000000 for the GPIO I happen to be using. A simple application of !! solves that though. Tested on a RuggedCom RX5000 (mpc8360e based). Signed-off-by: Lennart Sorensen <lsorense@...lub.uwaterloo.ca> diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c index 8659d34..7e76f0c 100644 --- a/drivers/net/phy/mdio-gpio.c +++ b/drivers/net/phy/mdio-gpio.c @@ -55,7 +55,7 @@ static int mdio_get(struct mdiobb_ctrl *ctrl) struct mdio_gpio_info *bitbang = container_of(ctrl, struct mdio_gpio_info, ctrl); - return gpio_get_value(bitbang->mdio); + return !!gpio_get_value(bitbang->mdio); } static void mdio_set(struct mdiobb_ctrl *ctrl, int what) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists