lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 09 Nov 2009 14:34:17 -0800
From:	David Daney <>
To:	Wu Zhangjin <>
	Ralf Baechle <>,,
	Frederic Weisbecker <>,
	Ingo Molnar <>,
	Nicholas Mc Guire <>,
	Richard Sandiford <>,
	Patrik Kluba <>,
	Thomas Gleixner <>,
	Michal Simek <>
Subject: Re: [PATCH v7 17/17] tracing: make function graph tracer work with

Wu Zhangjin wrote:
> +	cflags-y += $(call cc-option, -mmcount-ra-address)
> +#if (__GNUC__ <= 4 && __GNUC_MINOR__ < 5)

Sprinkling the code with these #if clauses is ugly and prone to breakage 
I think.

The Makefile part is testing for the same feature.

We do a very similar thing with -msym32, and KBUILD_SYM32.  Perhaps you 
could rework this patch in a similar manner and test for 
KBUILD_MCOUNT_RA_ADDRESS instead of the '(__GNUC__ <= 4 && 
__GNUC_MINOR__ < 5)'

David Daney
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists