lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Nov 2009 14:34:17 -0800 From: David Daney <ddaney@...iumnetworks.com> To: Wu Zhangjin <wuzhangjin@...il.com> CC: linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org, zhangfx@...ote.com, zhouqg@...il.com, Ralf Baechle <ralf@...ux-mips.org>, rostedt@...dmis.org, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...e.hu>, Nicholas Mc Guire <der.herr@...r.at>, Richard Sandiford <rdsandiford@...glemail.com>, Patrik Kluba <kpajko79@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Michal Simek <monstr@...str.eu> Subject: Re: [PATCH v7 17/17] tracing: make function graph tracer work with -mmcount-ra-address Wu Zhangjin wrote: [...] > + cflags-y += $(call cc-option, -mmcount-ra-address) [...] > +#if (__GNUC__ <= 4 && __GNUC_MINOR__ < 5) Sprinkling the code with these #if clauses is ugly and prone to breakage I think. The Makefile part is testing for the same feature. We do a very similar thing with -msym32, and KBUILD_SYM32. Perhaps you could rework this patch in a similar manner and test for KBUILD_MCOUNT_RA_ADDRESS instead of the '(__GNUC__ <= 4 && __GNUC_MINOR__ < 5)' David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists