linux-kernel - Re: [PATCH] Staging: rt28x0: remove no longer needed common/cmm_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Nov 2009 22:59:42 +0000
From:	Darren Salt <linux@...mustbejoking.demon.co.uk>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rt28x0: remove no longer needed common/cmm_data_2860.c

I demand that Bartlomiej Zolnierkiewicz may or may not have written...

> On Monday 09 November 2009 18:54:38 Darren Salt wrote:
>> Your removal of cmm_data_2860.c also removes a bug fix (commit
>> 0af49167b1e5ba154e90d2c454bf4624ee47df80; for background, see
>> http://bugzilla.kernel.org/show_bug.cgi?id=13390).

> commit 0af49167b1e5ba154e90d2c454bf4624ee47df80
> Author: Darren Salt <linux@...mustbejoking.demon.co.uk>
> Date:   Wed Oct 14 02:19:22 2009 +0100
>     Staging: rt2860sta: prevent a panic when disabling when associated

> while:

> ommit 5d315c4baa7be30e0fb8c924a64406492b2263b8
> Author: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Date:   Tue Sep 22 20:44:07 2009 +0200
>     Staging: rt28x0: updates from vendor's V2.1.0.0 drivers

> dropped cmm_data_2860.o from the build..

Ouch. ;-)

[snip]
>> Is this fix present (or, better, not needed) in the code which obsoletes
>> this file? (I can test if needed; just point me in the right direction
>> wrt patches or repositories.)

> It seems it is still needed so could you port it over to cmm_data_pci.c
> (just use staging or linux-next as a base)?

I've tested with the Ralink drivers from -next copied into my 2.6.32-rc6 tree
(which has one bad patch from -rc5 reverted, else the bug would be masked),
and all appears to be working well.

So, unless you think that extra belt and braces would be of use here, I'm not
going to bother porting it.

-- 
| Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + http://www.youmustbejoking.demon.co.uk/

Pssst... the root password is 'kumquat'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/