linux-kernel - serial_cs: oxsemi quirk breaks resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091110075410.GA6157@ucw.cz>
Date:	Tue, 10 Nov 2009 08:54:11 +0100
From:	Pavel Machek <pavel@....cz>
To:	kernel list <linux-kernel@...r.kernel.org>, gregkh@...e.de,
	KMoorman@...nsy.edu, w.sang@...gutronix.de,
	ken_kawasaki@...ing.nifty.jp, davem@...emloft.net,
	Andrew Morton <akpm@...l.org>, alan@...rguk.ukuu.org.uk
Subject: serial_cs: oxsemi quirk breaks resume


Quirk is applied on all cards with given manfid (is it that
correct?). Unfortunately, that quirk breaks resume on zaurus with
billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.

Signed-off-by: Pavel Machek <pavel@....cz>

--- a/drivers/serial/serial_cs.c	2009-10-06 13:51:46.000000000 +0200
+++ b/drivers/serial/serial_cs.c	2009-11-09 14:43:25.000000000 +0100
@@ -158,7 +158,8 @@
 {
 	struct serial_info *info = link->priv;
 
-	outb(12, info->c950ctrl + 1);
+	if (info->c950ctrl)
+		outb(12, info->c950ctrl + 1);
 }
 
 /* request_region? oxsemi branch does no request_region too... */


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/