linux-kernel - Re: [PATCH] parport_pc.c: Use correct length in strncmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091110102518.7c3fc47c@lxorguk.ukuu.org.uk>
Date:	Tue, 10 Nov 2009 10:25:18 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Joe Perches <joe@...ches.com>
Cc:	Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parport_pc.c: Use correct length in strncmp

On Mon, 09 Nov 2009 19:51:23 -0800
Joe Perches <joe@...ches.com> wrote:

> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index 2597145..ad113b0 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -3403,7 +3403,7 @@ static int __init parport_parse_param(const char *s, int *val,
>  		*val = automatic;
>  	else if (!strncmp(s, "none", 4))
>  		*val = none;
> -	else if (nofifo && !strncmp(s, "nofifo", 4))
> +	else if (nofifo && !strncmp(s, "nofifo", 6))
>  		*val = nofifo;

I just hope nobody is booting with =nofif due to a typo ;)

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/