lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Nov 2009 13:36:37 +0200 From: "Michael S. Tsirkin" <mst@...hat.com> To: Rusty Russell <rusty@...tcorp.com.au> Cc: netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, mingo@...e.hu, linux-mm@...ck.org, akpm@...ux-foundation.org, hpa@...or.com, gregory.haskins@...il.com, s.hetze@...ux-ag.com, Daniel Walker <dwalker@...o99.com>, Eric Dumazet <eric.dumazet@...il.com> Subject: Re: [PATCHv9 3/3] vhost_net: a kernel-level virtio server On Tue, Nov 10, 2009 at 01:49:09PM +1030, Rusty Russell wrote: > One fix: > > vhost: fix TUN=m VHOST_NET=y > > drivers/built-in.o: In function `get_tun_socket': > net.c:(.text+0x15436e): undefined reference to `tun_get_socket' > > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au> > --- > drivers/vhost/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig > --- a/drivers/vhost/Kconfig > +++ b/drivers/vhost/Kconfig > @@ -1,6 +1,6 @@ > config VHOST_NET > tristate "Host kernel accelerator for virtio net (EXPERIMENTAL)" > - depends on NET && EVENTFD && EXPERIMENTAL > + depends on NET && EVENTFD && TUN && EXPERIMENTAL > ---help--- > This kernel module can be loaded in host kernel to accelerate > guest networking with virtio_net. Not to be confused with virtio_net In fact, vhost can be built with TUN=n VHOST_NET=y as well (tun_get_socket is stubbed out in that case). So I think this is better (it looks strange until you realize that for tristate variables boolean logic math does not apply): ---> From: Michael S. Tsirkin <mst@...hat.com> Subject: vhost: fix TUN=m VHOST_NET=y drivers/built-in.o: In function `get_tun_socket': net.c:(.text+0x15436e): undefined reference to `tun_get_socket' If tun is a module, vhost must be a module, too. If tun is built-in or disabled, vhost can be built-in. Signed-off-by: Michael S. Tsirkin <mst@...hat.com> --- diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index 9f409f4..9e93553 100644 --- a/drivers/vhost/Kconfig +++ b/drivers/vhost/Kconfig @@ -1,6 +1,6 @@ config VHOST_NET tristate "Host kernel accelerator for virtio net (EXPERIMENTAL)" - depends on NET && EVENTFD && EXPERIMENTAL + depends on NET && EVENTFD && (TUN || !TUN) && EXPERIMENTAL ---help--- This kernel module can be loaded in host kernel to accelerate guest networking with virtio_net. Not to be confused with virtio_net -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists