linux-kernel - Re: spitz battery driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2009 14:25:26 +0100
From:	Pavel Machek <pavel@....cz>
To:	Stanislav Brabec <utx@...guin.cz>
Cc:	Eric Miao <eric.y.miao@...il.com>,
	zaurus-devel@...ts.linuxtogo.org, rpurdie@...ys.net,
	lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>,
	Dirk@...er-online.de, arminlitzel@....de,
	Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	dbaryshkov@...il.com, omegamoon@...il.com,
	Paul Fertser <fercerpav@...il.com>
Subject: Re: spitz battery driver

k
> > > This is a good move. However, I assume the patch is still RFC now.
> > > Or basically the coding style cleanup can be separated into another
> > > patch?
> > 
> > Its rfc now. Parts of codingstyle cleanup should already be in your
> > tree, I'll rediff it later.
> 
> Pavel, could you compare your patch with the "power: implement platform
> battery driver"??? patches from Paul Fertser just sent to LKML and
> zaurus-devel list? Would it be complicated to migrate to it? I guess

Complicated? No. Useful? Probably also no. Remove 50 lines for
additional indirection? I'd prefer not to.

> that use of platform driver could allow to recycle major parts of the
> charging driver by more devices.

take a look at those patches. I'd rather use mainline battery api.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/