linux-kernel - Re: [PATCH] scsi_lib_dma.c : fix bug with dma maps on nested scsi objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AF97AF5.2090700@emulex.com>
Date:	Tue, 10 Nov 2009 09:38:45 -0500
From:	James Smart <James.Smart@...lex.Com>
To:	James Bottomley <James.Bottomley@...e.de>
CC:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andrew.vasquez@...gic.com" <andrew.vasquez@...gic.com>,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>
Subject: Re: [PATCH] scsi_lib_dma.c :  fix bug with dma maps on nested scsi
 objects - (2nd try)

James,

This updated patch works fine for lpfc and our vports...

Acked-By: James Smart  <james.smart@...lex.com>

-- james s


James Bottomley wrote:
> 
> 141 lines plus a static list to solve a simple problem is getting a bit
> icky to say the least.
> 
> What about being more simplistic and simply making the host cache a
> pointer to the physical bus device?  I probably objected to this a long
> time ago because using the parent pointers is more elegant, but I think
> this patch demonstrates conclusively it's not worth this amount of code
> for the sake of alleged elegance.
> 
> James
> 
> ---
>  drivers/scsi/hosts.c            |   13 ++++++++++---
>  drivers/scsi/lpfc/lpfc_init.c   |    2 +-
>  drivers/scsi/qla2xxx/qla_attr.c |    3 ++-
>  drivers/scsi/scsi_lib_dma.c     |    4 ++--
>  include/scsi/scsi_host.h        |   16 +++++++++++++++-
>  5 files changed, 30 insertions(+), 8 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/