linux-kernel - Re: [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2009 12:49:14 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Amit Shah <amit.shah@...hat.com>
Cc:	Anthony Liguori <aliguori@...ibm.com>,
	linux-kernel@...r.kernel.org, virtualization@...ux-foundation.org,
	Christian Borntraeger <borntraeger@...ibm.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication

On Mon, 9 Nov 2009 10:38:39 pm Amit Shah wrote:
> > 3) Don't use list_for_each_safe() to get the head entry of a list.  Your
> >    use is buggy anyway: buf will never be NULL afterwards.
> 
> As long as 'head' isn't the only node in the list we should loop. And
> list_foreach_safe() does that. So it's OK right?

If there's more than one, buf will be == head.

> I'm sorry for having created more work for you; I'll send out my patches
> to you in a couple of days.

I spent some time on the weekend creating patches.  They're not finished,
but they start the process of maturing the driver to where it can handle
multiple ports.

The next step is real buffer management (ie. the infrastructure for more than
one in flight, even though the normal console won't do this), then adding
headers.

I will post them now so you can take a look...
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/