linux-kernel - Re: [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1257871514.3007.23.camel@ppwaskie-mobl2>
Date:	Tue, 10 Nov 2009 08:45:14 -0800
From:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
To:	Ali Gholami Rudi <ali@...i.ir>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>
Subject: Re: [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()

On Tue, 2009-11-10 at 08:40 -0800, Ali Gholami Rudi wrote:
> The values of r_idx and rx_ring are not used after the last time they
> are set in ixgbe_msix_clean_rx(), so they can be removed.
> 

Thanks for cleaning this up.

Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>

> Signed-off-by: Ali Gholami Rudi <ali@...i.ir>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 5bd9e6b..6541c80 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
>  	if (!q_vector->rxr_count)
>  		return IRQ_HANDLED;
>  
> -	r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
> -	rx_ring = &(adapter->rx_ring[r_idx]);
>  	/* disable interrupts on this vector only */
>  	ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
>  	napi_schedule(&q_vector->napi);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/