[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091110172337.2236ad58@lxorguk.ukuu.org.uk>
Date: Tue, 10 Nov 2009 17:23:37 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Bryan Donlan <bdonlan@...il.com>,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
Timo Sirainen <tss@....fi>,
Ulrich Drepper <drepper@...hat.com>,
WANG Cong <xiyou.wangcong@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: + prctl-add-pr_set_proctitle_area-option.patch added to -mm
tree
> Yes, we can't do access_process_vm() under ->mmap_sem, but we can add
> the new helper, say, access_process_vm_locked(tsk, mm, ...) which does
> the actual work. Then proc_pid_cmdline() can take mmap_sem for reading,
> read arg_start/arg_end and call access_process_vm_locked().
It might not be a bad idea if whoever wrote it spent about 60 seconds
thinking about maths overflow as well. I'm not sure some of the tools
will react too well if end is before start.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists