linux-kernel - Re: [PATCH] ALPS: Add support for 4 directions button on Acer Aspire 5720

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091110173047.GC15263@core.coreip.homeip.net>
Date:	Tue, 10 Nov 2009 09:30:47 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Vojtech Pavlik <vojtech@...e.cz>
Subject: Re: [PATCH] ALPS: Add support for 4 directions button on Acer
	Aspire 5720

Hi Maxim,

On Tue, Nov 10, 2009 at 12:03:47PM +0200, Maxim Levitsky wrote:
> @@ -483,8 +529,13 @@ int alps_init(struct psmouse *psmouse)
>  	}
>  
>  	if (priv->i->flags & (ALPS_FW_BK_1 | ALPS_FW_BK_2)) {
> -		dev1->keybit[BIT_WORD(BTN_FORWARD)] |= BIT_MASK(BTN_FORWARD);
> -		dev1->keybit[BIT_WORD(BTN_BACK)] |= BIT_MASK(BTN_BACK);
> +		dev1->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_0);
> +		dev1->keybit[BIT_WORD(BTN_1)] |= BIT_MASK(BTN_1);
> +	}
> +
> +	if (priv->i->flags & ALPS_EXTRA) {
> +		dev1->keybit[BIT_WORD(BTN_2)] |= BIT_MASK(BTN_2);
> +		dev1->keybit[BIT_WORD(BTN_3)] |= BIT_MASK(BTN_3);
>  	}
>  

Please don;t do this, you are breaking existing users. Add
ALPS_FOUR_BUTTONS flag and use it to report BTN_0..BTN_3 in your case.

I am also unsure if we need to do DMI entry, I'll try to dig original
submisison for that signature and see...

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/