linux-kernel - Re: [PATCH] drm/radeon/kms: disable load detection on TV output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2009 20:59:22 +0000 (GMT)
From:	Dave Airlie <airlied@...ux.ie>
To:	Jerome Glisse <jglisse@...hat.com>
cc:	airlied@...il.com, linux-kernel@...r.kernel.org,
	dri-devel@...ts.sf.net
Subject: Re: [PATCH] drm/radeon/kms: disable load detection on TV output


> Do like in the DDX don't try to load detect TV output, there is a lot
> of false positive detection with those code. Seems to be isolated to
> RS480/RC410 chipset thought. Need more investigations.
> 

NAK, I've not seen any false positive bug reports other than rs480, and
I suspect that is some timing difference due to different ref clock, I've 
tested this code on my r100/r200/r300 cards and seemed to always work 
fine.

So just turn it off for rs480, I'm also seeing a lot of rs480 reporting tv
connectors that don't exist, has the person got a real connector?

Dave.

 > Signed-off-by: Jerome Glisse 
<jglisse@...hat.com>
> ---
>  drivers/gpu/drm/radeon/radeon_connectors.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index fce4c40..292b170 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1015,7 +1015,7 @@ radeon_add_atom_connector(struct drm_device *dev,
>  			ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
>  			if (ret)
>  				goto failed;
> -			radeon_connector->dac_load_detect = true;
> +			radeon_connector->dac_load_detect = false;
>  			drm_connector_attach_property(&radeon_connector->base,
>  						      rdev->mode_info.load_detect_property,
>  						      1);
> @@ -1148,7 +1148,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
>  			ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
>  			if (ret)
>  				goto failed;
> -			radeon_connector->dac_load_detect = true;
> +			radeon_connector->dac_load_detect = false;
>  			drm_connector_attach_property(&radeon_connector->base,
>  						      rdev->mode_info.load_detect_property,
>  						      1);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/