lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Nov 2009 22:22:05 +0100 From: Jan Kara <jack@...e.cz> To: Tao Ma <tao.ma@...cle.com> Cc: linux-kernel@...r.kernel.org, sunil.mushran@...cle.com, Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz> Subject: Re: [PATCH] JBD/JBD2: free j_wbuf if journal init fails. On Tue 10-11-09 17:13:22, Tao Ma wrote: > If journal init fails, we need to free j_wbuf. Thanks, added to my tree. Honza > > Cc: Andrew Morton <akpm@...ux-foundation.org> > Cc: Jan Kara <jack@...e.cz> > Signed-off-by: Tao Ma <tao.ma@...cle.com> > --- > fs/jbd/journal.c | 2 ++ > fs/jbd2/journal.c | 2 ++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c > index bd3c073..49d5cd6 100644 > --- a/fs/jbd/journal.c > +++ b/fs/jbd/journal.c > @@ -756,6 +756,7 @@ journal_t * journal_init_dev(struct block_device *bdev, > > return journal; > out_err: > + kfree(journal->j_wbuf); > kfree(journal); > return NULL; > } > @@ -820,6 +821,7 @@ journal_t * journal_init_inode (struct inode *inode) > > return journal; > out_err: > + kfree(journal->j_wbuf); > kfree(journal); > return NULL; > } > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index b0ab521..fed8538 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -913,6 +913,7 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev, > > return journal; > out_err: > + kfree(journal->j_wbuf); > jbd2_stats_proc_exit(journal); > kfree(journal); > return NULL; > @@ -986,6 +987,7 @@ journal_t * jbd2_journal_init_inode (struct inode *inode) > > return journal; > out_err: > + kfree(journal->j_wbuf); > jbd2_stats_proc_exit(journal); > kfree(journal); > return NULL; > -- > 1.5.4.4 > -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists