linux-kernel - Re: [PATCH] ALSA: possible read past array alc88[02]_parse_auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hskcl5yj2.wl%tiwai@suse.de>
Date:	Wed, 11 Nov 2009 08:08:33 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: possible read past array alc88[02]_parse_auto_config()

At Tue, 10 Nov 2009 20:11:55 +0100,
Roel Kluin wrote:
> 
> The test of index `i' is after the read - too late - and
> unsafe: if snd_hda_get_connections() fails in the last
> iteration a read beyond the array is possible.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Applied now.  Thanks!


Takashi

> ---
>  sound/pci/hda/patch_realtek.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ff20048..fd094f5 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4684,9 +4684,9 @@ static int alc880_parse_auto_config(struct hda_codec *codec)
>  			spec->multiout.dig_out_nid = dig_nid;
>  		else {
>  			spec->multiout.slave_dig_outs = spec->slave_dig_outs;
> -			spec->slave_dig_outs[i - 1] = dig_nid;
> -			if (i == ARRAY_SIZE(spec->slave_dig_outs) - 1)
> +			if (i >= ARRAY_SIZE(spec->slave_dig_outs) - 1)
>  				break;
> +			spec->slave_dig_outs[i - 1] = dig_nid;
>  		}
>  	}
>  	if (spec->autocfg.dig_in_pin)
> @@ -9813,9 +9813,9 @@ static int alc882_parse_auto_config(struct hda_codec *codec)
>  			spec->multiout.dig_out_nid = dig_nid;
>  		else {
>  			spec->multiout.slave_dig_outs = spec->slave_dig_outs;
> -			spec->slave_dig_outs[i - 1] = dig_nid;
> -			if (i == ARRAY_SIZE(spec->slave_dig_outs) - 1)
> +			if (i >= ARRAY_SIZE(spec->slave_dig_outs) - 1)
>  				break;
> +			spec->slave_dig_outs[i - 1] = dig_nid;
>  		}
>  	}
>  	if (spec->autocfg.dig_in_pin)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/