[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Nov 2009 03:20:23 -0500
From: Nathaniel McCallum <nathaniel@...emccallum.com>
To: linux-kernel@...r.kernel.org
Subject: [PATCH] Devices that ignore USB spec generate invalid modaliases
Please CC me as I'm not subscribed to LKML.
The current code to generate usb modaliases from usb_device_id assumes
that the device's bcdDevice descriptor will actually be in BCD format.
While this should be a sane assumption, some devices don't follow spec
and just use plain old hex. This causes drivers for these devices to
generate invalid modalias lines which will never actually match for the
hardware.
The following patch adds hex support for bcdDevice in file2alias.c.
Drivers for devices which have bcdDevice conforming to BCD will have no
change in modalias output. Drivers for devices which don't conform
(primarily usb-storage and ibmcam in my initial survey) should now
generate valid modaliases.
EXAMPLE OUTPUT (ibmcam; space added to highlight change)
Old: usb:v0545p800D d030[10-9] dc*dsc*dp*ic*isc*ip*
New: usb:v0545p800D d030a dc*dsc*dp*ic*isc*ip*
Patch attached. Questions/comments welcome.
Nathaniel McCallum
View attachment "file2alias_usb_bcd2hex.patch" of type "text/plain" (1503 bytes)
Powered by blists - more mailing lists