linux-kernel - Re: [PATCH v2] Add poll_get_char and poll_put_char uart_ops to atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091111113713.GC2605@pc-ran3241.res.insa>
Date:	Wed, 11 Nov 2009 12:37:13 +0100
From:	Albin Tonnerre <albin.tonnerre@...e-electrons.com>
To:	akpm@...ux-foundation.org
Cc:	linux-kernel@...r.kernel.org, haavard.skinnemoen@...el.com,
	avictor.za@...il.com
Subject: Re: [PATCH v2] Add poll_get_char and poll_put_char uart_ops to
 atmel_serial.

Andrew, could you please pick this up ? It got:

Acked-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Acked-by: Andrew Victor <linux@...im.org.za>

Regards,
Albin

On Mon, 07 Sep 2009 11:52 +0200, Albin Tonnerre wrote :
> This patch allows using KGDB over the console with the atmel_serial
> driver.
> 
> Signed-off-by: Albin Tonnerre <albin.tonnerre@...e-electrons.com>
> ---
> changes: Use register access macros instead of __raw_readl/writel
> 
>  drivers/serial/atmel_serial.c |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c
> index 607d43a..c562883 100644
> --- a/drivers/serial/atmel_serial.c
> +++ b/drivers/serial/atmel_serial.c
> @@ -1213,6 +1213,24 @@ static int atmel_verify_port(struct uart_port *port, struct serial_struct *ser)
>  	return ret;
>  }
>  
> +#ifdef CONFIG_CONSOLE_POLL
> +static int atmel_poll_get_char(struct uart_port *port)
> +{
> +	while (!(UART_GET_CSR(port) & ATMEL_US_RXRDY))
> +		barrier();
> +
> +	return UART_GET_CHAR(port);
> +}
> +
> +static void atmel_poll_put_char(struct uart_port *port, unsigned char ch)
> +{
> +	while (!(UART_GET_CSR(port) & ATMEL_US_TXRDY))
> +		barrier();
> +
> +	UART_PUT_CHAR(port, ch);
> +}
> +#endif
> +
>  static struct uart_ops atmel_pops = {
>  	.tx_empty	= atmel_tx_empty,
>  	.set_mctrl	= atmel_set_mctrl,
> @@ -1232,6 +1250,10 @@ static struct uart_ops atmel_pops = {
>  	.config_port	= atmel_config_port,
>  	.verify_port	= atmel_verify_port,
>  	.pm		= atmel_serial_pm,
> +#ifdef CONFIG_CONSOLE_POLL
> +	.poll_get_char	= atmel_poll_get_char,
> +	.poll_put_char	= atmel_poll_put_char,
> +#endif
>  };
>  
>  /*
-- 
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/