lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 14:11:48 +0000 From: Liam Girdwood <lrg@...mlogic.co.uk> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: linux-kernel@...r.kernel.org, Sascha Hauer <s.hauer@...gutronix.de>, Mark Brown <broonie@...nsource.wolfsonmicro.com>, Samuel Ortiz <sameo@...ux.intel.com> Subject: Re: [PATCH 2/2] regulator/mc13783: various cleanups On Tue, 2009-11-10 at 09:18 +0100, Uwe Kleine-König wrote: > - define needed registers and bits in the driver > - properly namespace functions and structs > - fix locking as required by patch > "mfd/mc13783: near complete rewrite" > - use platform_data as provided by "mfd/mc13783: near complete rewrite" > instead of accessing struct mc13783 > - struct mc13783_regulator_priv.desc is (and was) unused and so can go > away > - use cpp magic to initialize mc13783_regulators > - bring MODULE_LICENSE in sync with actual copyright > - minor style fixes > > This allows not including mc13783-private.h which I intend to remove > soon. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > Cc: Sascha Hauer <s.hauer@...gutronix.de> > Cc: Liam Girdwood <lrg@...mlogic.co.uk> > Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com> > Cc: Samuel Ortiz <sameo@...ux.intel.com> > --- I assume the new mc13783 function and type definitions are in mfd-next ? CC [M] drivers/regulator/mc13783-regulator.o drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_enable’: drivers/regulator/mc13783-regulator.c:116: error: implicit declaration of function ‘mc13783_lock’ drivers/regulator/mc13783-regulator.c:117: error: implicit declaration of function ‘mc13783_reg_rmw’ drivers/regulator/mc13783-regulator.c:120: error: implicit declaration of function ‘mc13783_unlock’ drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_is_enabled’: drivers/regulator/mc13783-regulator.c:148: error: implicit declaration of function ‘mc13783_reg_read’ drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_probe’: drivers/regulator/mc13783-regulator.c:175: error: dereferencing pointer to incomplete type drivers/regulator/mc13783-regulator.c:182: error: dereferencing pointer to incomplete type drivers/regulator/mc13783-regulator.c:183: error: dereferencing pointer to incomplete type drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_remove’: drivers/regulator/mc13783-regulator.c:215: error: dereferencing pointer to incomplete type make[1]: *** [drivers/regulator/mc13783-regulator.o] Error 1 make: *** [drivers/regulator/mc13783-regulator.o] Error 2 Liam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists