linux-kernel - [PATCH v4 0/2] bsearch: fix overflow and avoid unnecessary calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2009 13:00:23 -0200
From:	André Goddard Rosa <andre.goddard@...il.com>
To:	tabbott@...lice.com, alan-jenkins@...fmail.co.uk,
	rusty@...tcorp.com.au, linux-kernel@...r.kernel.org
Cc:	André Goddard Rosa <andre.goddard@...il.com>
Subject: [PATCH v4 0/2] bsearch: fix overflow and avoid unnecessary calculation

Fix a rare overflow situation which can occur when working with large arrays.
Also, remove an unneeded calculation.

changelog:
    v4: fix the overflow which could still happen when the number of array
        elements to search approached the maximum value of size_t and to
        find the key element we would need to traverse the whole binary tree
        (making 'start' idx tend towards 'end' idx), as pointed by review
        feedback from Rusty Russell (thanks!)
    v3: fix the comment/example of patch 02/02 at v2 patch series
    v2: fix a bug introduced into 01/02 of the v1 patch series
    v1: initial submission

André Goddard Rosa (2):
  bsearch: avoid unneeded decrement arithmetic
  bsearch: prevent overflow when computing middle comparison element

 lib/bsearch.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/