lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 19:32:57 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Dmitry Artamonow <mad_soft@...ox.ru> Cc: linux-arm-kernel@...ts.infradead.org, Randy Dunlap <randy.dunlap@...cle.com>, linux-kernel@...r.kernel.org Subject: Re: [REGRESSION] 2eca40a8 breaks StrongARM compilation On Wed, Nov 11, 2009 at 10:23:15PM +0300, Dmitry Artamonow wrote: > Commit 2eca40a8 which went into 2.6.32-rc6 breaks compilation > for ipaq h3600 and probably other SA1100 machines when CONFIG_CPU_FREQ > is unset: I'm aware, I have a very large patch which fixes SA1100, but there's other ARM machine classes which are similarly broken. We've been around this loop before, where a change like this was introduced and reverted. The kernel community seems set to constantly repeat the same old mistakes time and time again. > +#ifdef CONFIG_CPU_FREQ > pcd = get_pcd(var->pixclock, cpufreq_get(0)); > +#else > + pcd = get_pcd(var->pixclock, 206400); > +#endif This is just not acceptable, and could lead to LCD panel damage due to wrong timings - not all platforms boot at 206.4MHz. Given that it's far better that the kernel be obviously broken than silently wrong while causing hardware damage. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists