lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 20:37:20 +0100 From: Jens Axboe <jens.axboe@...cle.com> To: "Rafael J. Wysocki" <rjw@...k.pl> Cc: Pavel Machek <pavel@....cz>, Romit Dasgupta <romit@...com>, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, linux-pm@...ts.linux-foundation.org Subject: Re: [PATCH 1/1]: Thaws refrigerated bdi flusher threads before invoking kthread_stop on them On Wed, Nov 11 2009, Rafael J. Wysocki wrote: > On Wednesday 11 November 2009, Pavel Machek wrote: > > On Wed 2009-11-11 14:00:16, Romit Dasgupta wrote: > > > Kicks out frozen bdi flusher task out of the refrigerator when the flusher task > > > needs to exit. > > > > > > > Signed-off-by: Romit Dasgupta <romit@...com> > > > > Ok, its slightly "interesting", but better than modifying common > > code. Looks ok to me. > > > > ACK. > > Agreed. > > Jens, any objections? Nope, looks fine to me. Though I'd probably prefer just doing an unconditional PF_FROZEN clear. /* * Force unfreeze of the bdi threads before stopping it, since otherwise * it would never exit if it is stuck in the refrigerator. */ list_for_each_entry(wb, &bdi->wb_list, list) { wb->task->flags &= ~PF_FROZEN; kthread_stop(wb->task); } And the comment too, it's not enough to stuff this into the commit. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists