linux-kernel - Re: [RFC] new -stable tag variant, Git workflow question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2009 12:00:35 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
cc:	Greg KH <gregkh@...e.de>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Wright <chrisw@...s-sol.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC] new -stable tag variant, Git workflow question

On Wed, 11 Nov 2009, James Bottomley wrote:
> 
> The slight problem is that further down, to generate the patch the
> script uses git format-patch -k --stdout commit^..commit.  For a merge
> commit, this will generate a patch equivalent to the entire branch that
> was merged, even though the commit message will only pick out some of
> these ... is this OK?

Don't do that.

Since you want to show a single commit, not a commit range, don't use 
format-patch, use something like

	git show --pretty=email -M --cc --stat $commit

instead. That will not show the difference between a commit and its 
first parent (which for a merge diff is more than one commit, and can be 
absolutely _huge_), but will show just the named commit (which for a merge 
commit will usually be an empty diff, but will show how conflicts were 
resolved if they weren't just taken from one or the other side).

(Of course, maybe you'll want to change the exact flags in question. For 
example, '--stat' for merge commits is often useful, but only if the merge 
was done by an upper-level maintainer. Anybody who does reverse merges 
will just get totally meaningless diffstats, since the diffstat is always 
done against the first parent, so anybody who does back-merges will see 
the stat of everthing _I_ have merged in the meantime, which is generally 
not useful)

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/