lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 12:25:54 -0800 (PST) From: Linus Torvalds <torvalds@...ux-foundation.org> To: Marcel Holtmann <marcel@...tmann.org> cc: "Rafael J. Wysocki" <rjw@...k.pl>, Thomas Gleixner <tglx@...utronix.de>, Mike Galbraith <efault@....de>, Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>, pm list <linux-pm@...ts.linux-foundation.org>, Greg KH <gregkh@...e.de>, Jesse Barnes <jbarnes@...tuousgeek.org>, Tejun Heo <tj@...nel.org>, Oleg Nesterov <oleg@...hat.com>, Oliver Neukum <oliver@...kum.org>, linux-bluetooth@...r.kernel.org Subject: Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) On Wed, 11 Nov 2009, Marcel Holtmann wrote: > > As it seems the btusb_close() only cancels the work workqueue and not > the waker workqueue. Could that be the problem. It's the waker workqueue that Rafael apparently sees with the debug patch from Oleg, so yeah, that sounds possible. Rafael, since apparently htusb_close() _is_ called, does the following simpler patch fix it for you? I bet your patch does it too. Linus --- drivers/bluetooth/btusb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7ba91aa..2fb3802 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -591,6 +591,7 @@ static int btusb_close(struct hci_dev *hdev) return 0; cancel_work_sync(&data->work); + cancel_work_sync(&data->waker); clear_bit(BTUSB_ISOC_RUNNING, &data->flags); clear_bit(BTUSB_BULK_RUNNING, &data->flags); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists