lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 23:07:57 +0100 From: Roel Kluin <roel.kluin@...il.com> To: Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, David Brownell <dbrownell@...rs.sourceforge.net>, spi-devel-general@...ts.sourceforge.net Subject: [PATCH] spi: Should error status be negative? Return a negative error value instead of a positive Signed-off-by: Roel Kluin <roel.kluin@...il.com> --- drivers/spi/spi_stmp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) is this maybe required? diff --git a/drivers/spi/spi_stmp.c b/drivers/spi/spi_stmp.c index d871dc2..2552bb3 100644 --- a/drivers/spi/spi_stmp.c +++ b/drivers/spi/spi_stmp.c @@ -242,7 +242,7 @@ static int stmp_spi_txrx_dma(struct stmp_spi *ss, int cs, wait_for_completion(&ss->done); if (!busy_wait(readl(ss->regs + HW_SSP_CTRL0) & BM_SSP_CTRL0_RUN)) - status = ETIMEDOUT; + status = -ETIMEDOUT; if (!dma_buf) dma_unmap_single(ss->master_dev, spi_buf_dma, len, dir); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists