lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 11:42:04 +0900 (JST) From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Cc: kosaki.motohiro@...fujitsu.com, Hugh Dickins <hugh.dickins@...cali.co.uk>, Andrew Morton <akpm@...ux-foundation.org>, Izik Eidus <ieidus@...hat.com>, Andrea Arcangeli <aarcange@...hat.com>, Minchan Kim <minchan.kim@...il.com>, Andi Kleen <andi@...stfloor.org>, Wu Fengguang <fengguang.wu@...el.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH 6/6] mm: sigbus instead of abusing oom > On Tue, 10 Nov 2009 22:06:49 +0000 (GMT) > Hugh Dickins <hugh.dickins@...cali.co.uk> wrote: > > > When do_nonlinear_fault() realizes that the page table must have been > > corrupted for it to have been called, it does print_bad_pte() and > > returns ... VM_FAULT_OOM, which is hard to understand. > > > > It made some sense when I did it for 2.6.15, when do_page_fault() > > just killed the current process; but nowadays it lets the OOM killer > > decide who to kill - so page table corruption in one process would > > be liable to kill another. > > > > Change it to return VM_FAULT_SIGBUS instead: that doesn't guarantee > > that the process will be killed, but is good enough for such a rare > > abnormality, accompanied as it is by the "BUG: Bad page map" message. > > > > And recent HWPOISON work has copied that code into do_swap_page(), > > when it finds an impossible swap entry: fix that to VM_FAULT_SIGBUS too. > > > > Signed-off-by: Hugh Dickins <hugh.dickins@...cali.co.uk> > > Thank you ! > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Thank you, me too. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists