linux-kernel - Re: keyboard leds not restored after s2ram in 2.6.32-rc6-00166-g799dd75

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Nov 2009 00:08:39 -0800 (PST)
From:	Mikko Vinni <mmvinni@...oo.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: keyboard leds not restored after s2ram in 2.6.32-rc6-00166-g799dd75

From: Dmitry Torokhov <dmitry.torokhov@...il.com>

> > I did some tests suspending with the caps lock actually on, and it seems that
> > in that case the user might still be confused (caps lock is on but led is 
> off).
> > At least on this machine this patch doesn't affect this theoretical problem
> > either way (2.6.31 behaves similarly), so it is ok.
> > 
> 
> Umm... so you are saying that even with .31 if you suspend with capslock
> on it is off when you resume? Does it happen only in X or in console as
> well?

It seems I judged a bit too early.
In console, both 2.6.31 and .32-rc6+your patch:
- suspending both with capslock on and off works as expected (same state in mode
and led after resume)

In X, both  2.6.31 and .32-rc6+your patch:
- suspending both with capslock on and off works; after resume same state
(typing procudes capital letters if capslock was on) and led shows the caplock
state
- if the capslock is on after resume, and I press shift before capslock key, the led
turns off but typing still produces capital letters. This, I think, is strange. This did
not happen in console, neither does pressing shift usually turn off the led.

So, apart from the minor nuisance of the shift key turning off the capslock led in X
even if typing still produces capital letters, everything seems to work as expected.


Mikko


> 
> -- 
> Dmitry



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/