linux-kernel - Re: [PATCH] drm/radeon/kms: Fix oops when set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1258023778.2473.2.camel@localhost>
Date:	Thu, 12 Nov 2009 12:02:58 +0100
From:	Jerome Glisse <jglisse@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	airlied@...il.com, dri-devel@...ts.sf.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/radeon/kms: Fix oops when set_base is call with no
 FB

On Tue, 2009-11-10 at 14:30 -0800, Andrew Morton wrote:
> On Wed,  4 Nov 2009 20:03:19 +0100
> Jerome Glisse <jglisse@...hat.com> wrote:
> 
> > Just do nothings crct_set_base i call with no FB.
> > 
> 
> hmpf.  It's obvious that you spent hours carefully describing this
> patch for us.
> 

Sorry, truth is i don't understand why crtc set_base call back
can be call with a null fb, i did just replicate what intel kms
and other part of radeon kms was doing in front of such situation.
It should go down to 2.6.31, useless before as there is no KMS
for radeon in earlier version. The oops will happen when user
switch btw X & vt or in some case when changing mode.

Will clearly state my ignorance in future patch.

Cheers,
Jerome

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/