linux-kernel - Re: [PATCH v4 2/2] bsearch: prevent overflow when computing middle comparison element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8bf37780911120523q79222fcdu6cb45997ab4b4e62@mail.gmail.com>
Date:	Thu, 12 Nov 2009 11:23:32 -0200
From:	André Goddard Rosa <andre.goddard@...il.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	tabbott@...lice.com, alan-jenkins@...fmail.co.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] bsearch: prevent overflow when computing middle 
	comparison element

On Thu, Nov 12, 2009 at 11:06 AM, Rusty Russell <rusty@...tcorp.com.au> wrote:
> On Wed, 11 Nov 2009 01:30:25 am André Goddard Rosa wrote:
>> It's really difficult to occur in practice because the sum of the lower
>> and higher limits must overflow an int variable, but it can occur when
>> working with large arrays. We'd better safe than sorry by avoiding this
>> overflow situation when computing the middle element for comparison.
>
> I applied all these, after testing.  In future would have been nice for you
> to have posted a test patch so I didn't have make my own...
>

Sure, no problem, thanks!

Kind regards,
André
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/