linux-kernel - Re: [PATCH] OSS: fix error return in dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hocn7y8qy.wl%tiwai@suse.de>
Date:	Thu, 12 Nov 2009 18:04:53 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]  OSS: fix error return in dma_ioctl()

At Thu, 12 Nov 2009 17:43:11 +0100,
Roel Kluin wrote:
> 
> The returned error should stay negative
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  sound/oss/audio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/oss/audio.c b/sound/oss/audio.c
> index b69c05b..7df48a2 100644
> --- a/sound/oss/audio.c
> +++ b/sound/oss/audio.c
> @@ -838,7 +838,7 @@ static int dma_ioctl(int dev, unsigned int cmd, void __user *arg)
>  					if ((err = audio_devs[dev]->d->prepare_for_input(dev,
>  						     dmap_in->fragment_size, dmap_in->nbufs)) < 0) {
>  						spin_unlock_irqrestore(&dmap_in->lock,flags);
> -						return -err;
> +						return err;

Hmm, looks like a wrong fix to me.
Here, err itself is already negative, so you don't need to flip the
sign.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/