linux-kernel - Re: [PATCH 13/17] hpsa: Retry driver initiated commands on unit attention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091112145248.35c76f52.akpm@linux-foundation.org>
Date:	Thu, 12 Nov 2009 14:52:48 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
Cc:	James.Bottomley@...senPartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	mikem@...rdog.cce.hp.com
Subject: Re: [PATCH 13/17] hpsa: Retry driver initiated commands on unit
 attention

On Wed, 11 Nov 2009 10:51:29 -0600
"Stephen M. Cameron" <scameron@...rdog.cce.hp.com> wrote:

> +static void hpsa_scsi_do_simple_cmd_with_retry(struct ctlr_info *h,
> +	struct CommandList *c, int data_direction)
> +{
> +	int retry_count = 0;
> +
> +	do {
> +		memset(c->err_info, 0, sizeof(c->err_info));
> +		hpsa_scsi_do_simple_cmd_core(h, c);
> +		retry_count++;
> +	} while (check_for_unit_attention(h, c) && retry_count <= 3);
> +	hpsa_pci_unmap(h->pdev, c, 1, data_direction);
> +}

If this times out, no indication of the error is returned to the caller
and no message is displayed to the operator.

Doesn't seem very robust?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/