lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Nov 2009 18:15:43 -0500 From: Dave Jones <davej@...hat.com> To: "H. Peter Anvin" <hpa@...or.com> Cc: Mike Travis <travis@....com>, Andi Kleen <ak@...ux.intel.com>, Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org>, Heiko Carstens <heiko.carstens@...ibm.com>, Roland Dreier <rdreier@...co.com>, Randy Dunlap <rdunlap@...otime.net>, Tejun Heo <tj@...nel.org>, Greg Kroah-Hartman <gregkh@...e.de>, Yinghai Lu <yinghai@...nel.org>, David Rientjes <rientjes@...gle.com>, Steven Rostedt <rostedt@...dmis.org>, Rusty Russell <rusty@...tcorp.com.au>, Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>, Jack Steiner <steiner@....com>, Frederic Weisbecker <fweisbec@...il.com>, x86@...nel.org, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] x86_64: Limit the number of processor bootup messages On Thu, Nov 12, 2009 at 02:57:33PM -0800, H. Peter Anvin wrote: > On 11/12/2009 02:22 PM, Dave Jones wrote: > > > > But I don't disagree with Andi either, that it's not particularly useful, > > and we can get all this from userspace in /proc/cpuinfo, or x86info. > > > > I personally don't think it's useful at all. It gives information about > the processor which can be obtained from other sources. What we want is > enough information that the CPU can be unambiguously identified, so that > when someone posts dmesg we can tell what machine they came from. In which case.. Dave --- Remove the CPU cache size printk's. They aren't useful, and pollute the dmesg output a lot (especially on machines with many cores). Also the same information can be trivially found out from userspace. Signed-off-by: Dave Jones <davej@...hat.com> diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c index 804c40e..868fcdd 100644 --- a/arch/x86/kernel/cpu/intel_cacheinfo.c +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c @@ -488,22 +493,6 @@ unsigned int __cpuinit init_intel_cacheinfo(struct cpuinfo_x86 *c) #endif } - if (trace) - printk(KERN_INFO "CPU: Trace cache: %dK uops", trace); - else if (l1i) - printk(KERN_INFO "CPU: L1 I cache: %dK", l1i); - - if (l1d) - printk(KERN_CONT ", L1 D cache: %dK\n", l1d); - else - printk(KERN_CONT "\n"); - - if (l2) - printk(KERN_INFO "CPU: L2 cache: %dK\n", l2); - - if (l3) - printk(KERN_INFO "CPU: L3 cache: %dK\n", l3); - c->x86_cache_size = l3 ? l3 : (l2 ? l2 : (l1i+l1d)); return l2; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists