linux-kernel - Re: Fix argument order in memset call in ./drivers/media/common/ir-functions.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Nov 2009 15:09:17 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Dave Jones <davej@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	kraxel@...esex.org, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: Fix argument order in memset call in ./drivers/media/common/ir-functions.c

On Thu, Nov 12, 2009 at 5:59 AM, Dave Jones <davej@...hat.com> wrote:
> Size is the third argument, not the second.
>
> Signed-off-by: Dave Jones <davej@...hat.com>


Definitely yes.

Acked-by: WANG Cong <xiyou.wangcong@...il.com>

>
> diff --git a/drivers/media/common/ir-functions.c b/drivers/media/common/ir-functions.c
> index 655474b..abd4791 100644
> --- a/drivers/media/common/ir-functions.c
> +++ b/drivers/media/common/ir-functions.c
> @@ -64,7 +64,7 @@ void ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
>
>        ir->ir_type = ir_type;
>
> -       memset(ir->ir_codes, sizeof(ir->ir_codes), 0);
> +       memset(ir->ir_codes, 0, sizeof(ir->ir_codes));
>
>        /*
>         * FIXME: This is a temporary workaround to use the new IR tables
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/