linux-kernel - Re: -next: Nov 12 - kernel BUG at kernel/sched.c:7359!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091113095801.GA29977@in.ibm.com>
Date:	Fri, 13 Nov 2009 15:28:01 +0530
From:	Gautham R Shenoy <ego@...ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Sachin Sant <sachinp@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Mike Galbraith <efault@....de>
Subject: Re: -next: Nov 12 - kernel BUG at kernel/sched.c:7359!

On Thu, Nov 12, 2009 at 06:10:31PM +0100, Peter Zijlstra wrote:
> 
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 1f2e99d..62df61c 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -2377,6 +2377,9 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
>  	task_rq_unlock(rq, &flags);
> 

How about this ?

again:
  	cpu = p->sched_class->select_task_rq(p, SD_BALANCE_WAKE, wake_flags);
 	if (!cpu_online(cpu))
 		cpu = cpumask_any_and(&p->cpus_allowed, cpu_active_mask);
	if (!cpu) {
		set_task_affinity(); 
		goto again;
	}
> +
>  	if (cpu != orig_cpu) {
>  		local_irq_save(flags);
>  		rq = cpu_rq(cpu);

Will it help further narrow down the window ?
> 
> 
> Something I think Mike also tried and didn't deadlock for him..
> 
> Sachin, Mike, could you try the above snippet and verify if it does
> indeed solve your respective issues?
> 
> /me prays it does, because otherwise I'm fresh out of clue...

-- 
Thanks and Regards
gautham
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/