linux-kernel - [PATCH update] ieee1394: Use hweight32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tkrat.057b967e5b8e4c33@s5r6.in-berlin.de>
Date:	Fri, 13 Nov 2009 12:53:08 +0100 (CET)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Akinobu Mita <akinobu.mita@...il.com>
cc:	linux1394-devel@...ts.sourceforge.net,
	Ben Collins <ben.collins@...ntu.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH update] ieee1394: Use hweight32

From: Akinobu Mita <akinobu.mita@...il.com>

Use hweight32 instead of counting for each bit

Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de> (add required include)
---

You forgot to include <linux/bitops.h>, probably also in some of the
other hweight patches which you sent today or yesterday.

 drivers/ieee1394/ohci1394.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Index: linux-2.6.31.4/drivers/ieee1394/ohci1394.c
===================================================================
--- linux-2.6.31.4.orig/drivers/ieee1394/ohci1394.c
+++ linux-2.6.31.4/drivers/ieee1394/ohci1394.c
@@ -82,6 +82,7 @@
  *
  */
 
+#include <linux/bitops.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/slab.h>
@@ -434,7 +435,6 @@ static void initialize_dma_trm_ctx(struc
 /* Count the number of available iso contexts */
 static int get_nb_iso_ctx(struct ti_ohci *ohci, int reg)
 {
-	int i,ctx=0;
 	u32 tmp;
 
 	reg_write(ohci, reg, 0xffffffff);
@@ -443,11 +443,7 @@ static int get_nb_iso_ctx(struct ti_ohci
 	DBGMSG("Iso contexts reg: %08x implemented: %08x", reg, tmp);
 
 	/* Count the number of contexts */
-	for (i=0; i<32; i++) {
-	    	if (tmp & 1) ctx++;
-		tmp >>= 1;
-	}
-	return ctx;
+	return hweight32(tmp);
 }
 
 /* Global initialization */

-- 
Stefan Richter
-=====-==--= =-== -==-=
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/