linux-kernel - Re: [PATCH 2.6.32] ftrace: fix event format export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3y6mazhij.fsf@hase.home>
Date:	Fri, 13 Nov 2009 14:22:28 +0100
From:	Andreas Schwab <schwab@...hat.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.32] ftrace: fix event format export

Johannes Berg <johannes@...solutions.net> writes:

> --- wireless-testing.orig/include/trace/ftrace.h	2009-11-13 13:15:21.000000000 +0100
> +++ wireless-testing/include/trace/ftrace.h	2009-11-13 13:34:03.000000000 +0100
> @@ -159,7 +159,7 @@
>  #undef __get_str
>  
>  #undef TP_printk
> -#define TP_printk(fmt, args...) "%s, %s\n", #fmt, __stringify(args)
> +#define TP_printk(fmt, args...) "\"%s\", %s\n", fmt, __stringify(args)

Would using __stringify(fmt) work?  If there are double quote characters
in fmt your solution would produce output that is ambiguous.

Andreas.

-- 
Andreas Schwab, schwab@...hat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/