linux-kernel - Re: [PATCH 2.6.32] ftrace: fix event format export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1258119168.6167.23.camel@johannes.local>
Date:	Fri, 13 Nov 2009 14:32:48 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Andreas Schwab <schwab@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.32] ftrace: fix event format export

On Fri, 2009-11-13 at 14:29 +0100, Johannes Berg wrote:

> > > -#define TP_printk(fmt, args...) "%s, %s\n", #fmt, __stringify(args)
> > > +#define TP_printk(fmt, args...) "\"%s\", %s\n", fmt, __stringify(args)
> > 
> > Would using __stringify(fmt) work?  If there are double quote characters
> > in fmt your solution would produce output that is ambiguous.

> However, isn't it already ambiguous that way? I fail to see why %s, #fmt
> would preserve inside " properly.

Never mind, I missed one indirection, so yes, it would preserve that. I
guess I'll have to somehow escape the quotes when copying them out to
userspace.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)