| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Nov 2009 20:38:03 +0100 From: Corrado Zoccolo <czoccolo@...il.com> To: Vivek Goyal <vgoyal@...hat.com> Cc: linux-kernel@...r.kernel.org, jens.axboe@...cle.com, nauman@...gle.com, dpshah@...gle.com, lizf@...fujitsu.com, ryov@...inux.co.jp, fernando@....ntt.co.jp, s-uchida@...jp.nec.com, taka@...inux.co.jp, guijianfeng@...fujitsu.com, jmoyer@...hat.com, balbir@...ux.vnet.ibm.com, righi.andrea@...il.com, m-ikeda@...jp.nec.com, akpm@...ux-foundation.org, riel@...hat.com, kamezawa.hiroyu@...fujitsu.com Subject: Re: [PATCH 05/16] blkio: Implement per cfq group latency target and busy queue avg On Fri, Nov 13, 2009 at 8:26 PM, Vivek Goyal <vgoyal@...hat.com> wrote: > On Fri, Nov 13, 2009 at 07:40:51PM +0100, Corrado Zoccolo wrote: >> Great. >> I have only one concern, regarding variable naming: >> group_target_lat is a bit misleading. The fact is that it will be >> larger for higher weight groups, so people could ask why are you >> giving more latency to higher weight group... >> Actually, it is the group share of the scheduling round, so you should >> name it accordingly. >> > > How about "group_slice" ? If you haven't something similar in other parts of the code, it will be fine Corrado > > Thanks > Vivek > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists