linux-kernel - Re: [PATCH 2/3] vc: Add support for hiding the cursor when creating VTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AFDDFF3.2070601@zytor.com>
Date:	Fri, 13 Nov 2009 14:38:43 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Matthew Garrett <mjg@...hat.com>
CC:	linux-kernel@...r.kernel.org, gregkh@...e.de
Subject: Re: [PATCH 2/3] vc: Add support for hiding the cursor when creating
 VTs

On 11/13/2009 11:57 AM, Matthew Garrett wrote:
>  
>  static int con_open(struct tty_struct *, struct file *);
>  static void vc_init(struct vc_data *vc, unsigned int rows,
> -		    unsigned int cols, int do_clear);
> +		    unsigned int cols, int do_clear)

Uhm... this doesn't compile.

I'm going to bounce this patch, not because I can't just add the
semicolon back and recompile it, but because that means you never
compiled it and therefore never tested it.

Please fix, test, and resubmit.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/